-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat+refactor: Bump MSRV to 1.83.0
and maximize const
#294
base: master
Are you sure you want to change the base?
Conversation
const
1.83.0
and maximize const
What's your motivation for this pull request? This currently raises the MSRV quite substantially, so it should have a good motivation, at the very least. |
I made this crate, and doing that was my motivation. The summary is: now that For now I've just forked this crate as |
Do you think this would be better served via a feature-flag? |
I would love if we could have something like this 👍 , honestly sooner rather than later as it blocks downstream libraries. 1.83 marks a huge shift in whats possible in A minimal version of this that would be sufficient for libraries would be a
|
I've created #296 as an alternative to this with the changes under the feature flag Instead of |
Find every
fn
which can beconst
(as of1.83.0
) and make it so. This involved moving all the implementations out of theArrayVecImpl
trait, which eventually left it unused, so I removed it.You could probably also remove
MakeMaybeUninit
and just havenew_const
callnew
if you wanted to.